Repository navigation
Launcher: console filter and quick console navigation - #19
Conversation
- Left / right on the game list jump to the previous / next console (the game buttons take left / right as keys: LV_OBJ_FLAG_USER_1 in Tab5Emu::keypad_read()). - The console above the boxart opens a console picker (tap it, X on a gamepad, F on a keyboard): all consoles, or only one console's games. The console is outlined while the list is filtered, and left / right then move the filter. Launching a game the filter hides lifts it. - The selected game is highlighted in the list (the theme has no checked style for list buttons, so it was not). - USB link (protocol 3, same remote_control.hpp / emulink as the box): CONSOLE_FILTER, the filter in STATUS, launcher screenshots. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
There was a problem hiding this comment.
🟡 Changes recommended
The filter query can reset focus and overwrite a newer selection, while resuming with the console picker open routes controls to the obscured game list and prevents dismissing the picker.
2 open issues
What changed in this PR
Extends the grouped launcher introduced in #18 with console filtering and faster navigation, and exposes these features through the USB control link.
Changes:
- Adds a console picker, left/right console navigation, and visible selection and filter indicators.
- Introduces protocol 3 support for console filtering and launcher screenshots.
- Adds
emulink filterand documents the new launcher controls.
| File | Description |
|---|---|
tools/emulink/emulink/control.py |
Adds console-filter client support and updates screenshot documentation. |
tools/emulink/emulink/cli.py |
Adds the filter command and updates screenshot help. |
README.md |
Documents console navigation, filtering, and USB usage. |
main/remote_control.hpp |
Implements protocol 3 filtering, filter status, and launcher screenshots. |
components/tab5-emu/src/tab5-emu.cpp |
Routes picker shortcuts and horizontal navigation keys. |
components/gui/src/gui.cpp |
Implements filtered lists, picker interactions, selection styling, and snapshots. |
components/gui/include/gui.hpp |
Declares filter and snapshot APIs and picker state. |
Review effort: Balanced
| if console is None: | ||
| console = self.status().get("filter", "") | ||
| # (an empty filter would clear it: ask for the same one again) | ||
| return self._call(CONSOLE_FILTER, (console or "all").encode()) |
There was a problem hiding this comment.
Fixed in 7613e0d: CONSOLE_FILTER with ? is a read-only query (reports {filter, consoles} without touching the list), and emulink filter with no argument sends that instead of writing the current filter back.
There was a problem hiding this comment.
Follow-up in 209cd4b: to match esp-box-emu (and its emulink), the query is now an empty CONSOLE_FILTER payload rather than ?; all clears the filter. Setting it also now runs on the main loop and is refused while a launch is pending.
ESP-IDF Size Report for 'Tab5 Emu'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
esp_tinyusb 3.0.1 (TinyUSB 0.21.0~6, the DWC2 SETUP-DMA erratum workaround) corrupts the PSRAM heap on esp-box-emu while a Genesis game runs (the link task's next allocation hits a tlsf assert or an MMU entry fault); 3.0.0 is fine. The Tab5 shares the USB device code, and a fresh build resolves '>=3.0.0' to 3.0.1, so pin it here too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
The heap corruption seen with Sonic 2 on the box turned out to be intermittent: the same builds that failed also pass repeated trials, so the runs that blamed esp_tinyusb 3.0.1 were not evidence of a cause. The corruption is tracked separately; no pin until it is understood. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
…ter query A game started from the PC (emulink launch) with the console picker open left it on screen after the game while the keypad drove the list behind it: resume() closes it. CONSOLE_FILTER takes "?" as a query that changes nothing, and emulink filter with no argument uses it instead of writing the current filter back. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
5 open issues
Storing an integer index invoid*viareinterpret_cast<void*>(i)is implementation-defined and… · Newbuild_list(i)already ends by selectingkeep_rom(here,i) when it’s valid, and then this… · New This will raise a KeyError if the device returns an error-shaped/partial JSON payload, or if the… · New Make argumentless filter queries read-only Restore the console picker when resuming
Review effort: Lite
…on indices; tolerant emulink filter output Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the launcher filtering, navigation, and USB control changes.
1 open issue
4 resolved since last review
This will raise a KeyError if the device returns an error-shaped/partial JSON payload, or if the…build_list(i)already ends by selectingkeep_rom(here,i) when it’s valid, and then this… Storing an integer index invoid*viareinterpret_cast<void*>(i)is implementation-defined and… Restore the console picker when resuming
Review effort: Balanced
…is pending; a list reload closes the picker
As esp-box-emu (3f9a022, 2968e88), so the protocol and emulink match:
- CONSOLE_FILTER with an empty payload returns {filter, consoles}
without touching the launcher ("all" clears the filter); emulink
filter with no console sends that query.
- Setting it runs on the main loop under the GUI lock, like LAUNCH, and
is refused while a launch the loop has taken has not started its cart.
- Re-reading metadata.csv closes an open console picker.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
…larifyCondition) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
main's tree is feat/console-filter's tip (b994815), already merged here, so this branch's tree is kept as is. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY

Follow-up to #18: the console above the boxart is now interactive. The same feature is in esp-box-emu, along with the same
remote_control.hppand emulink.LV_OBJ_FLAG_USER_1, soTab5Emu::keypad_read()passes them Left / Right as keys instead of focus moves.emulink filter <console|all>, the filter instatus, andemulink screenshotof the launcher when no game runs.Tested on the Tab5: picker by X / Down / A, Left / Right stepping, filters for all 6 consoles, a launch that lifts the filter, and the filter kept across a game.
Screenshots (
emulink screenshotof the launcher)The other consoles filtered (the badges are the firmware's own, since no console art is on the card):
🤖 Generated with Claude Code
https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY